tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

Fix output handling with filesAnalyzed

Open pombredanne opened this issue 4 years ago • 1 comments

This is a follow up to the closed PR https://github.com/spdx/tools-python/pull/192 by @lhh so we can have a discussion on the issue here.

The two commits messages were:

  • Include filesAnalyzed in machine-readable output 82be1b3

  • Fix filesAnalyzed handling f2a13d6 When filesAnalyzed is False, several sections should be omitted when omitting rather than being presented as empty sets or "None" SPDX 2.2, sec: 3.8.3 - files analyzed specification 3.9.3 - verification code 3.14.3 - licenses from files

pombredanne avatar Oct 13 '21 06:10 pombredanne

@lhh re: https://github.com/spdx/tools-python/pull/192#issuecomment-941451566

This needs more work; I'll reopen when it's passing.

Thank you in any case!

About https://github.com/spdx/tools-python/pull/192/commits/82be1b3f8a9d4f275545b4d8a87fb14091995699

... this is an area where we may thread lightly because quite often you may have files that do not have all details, or you do not have all files this is leading to some rather weird situation. I get your point of matching the spec, but at the same I would like to be practical and entirely omitting files if file_analyzed is False is going to be problematic for some use cases and users AFAIK. Ideally you might want to use some flag to enable some strict mode or not?

Also I would welcome some new tests with these changes.

pombredanne avatar Oct 13 '21 06:10 pombredanne

Closing this issue as it seems the discussion is done by now. Please speak up if it should be reopened.

armintaenzertng avatar Mar 30 '23 09:03 armintaenzertng