tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

Readme should mention need for DCO signed-off-by commits

Open altendky opened this issue 6 years ago • 4 comments

altendky avatar Aug 28 '19 21:08 altendky

CONTRIBUTING.MD gives a decent explanation of this project's DCO usage, but it's a valid complaint that README.md doesn't. How moving the "How to run tests" and "Developer workflow" to CONTRIBUTING.md, and leaving a link to that consolidated file in the README? I'd be willing to take on the writing.

SKalt avatar Oct 13 '19 16:10 SKalt

related PR: #121

SKalt avatar Oct 13 '19 17:10 SKalt

@SKalt so do you think we are good now?

pombredanne avatar Oct 16 '19 10:10 pombredanne

w/r/t information being present: yes, with enough reading a contributor should know how to sign off. I still think the contributing information could be better organized by consolidating it to CONTRIBUTING.md. PR incoming.

SKalt avatar Oct 16 '19 11:10 SKalt