tools-python icon indicating copy to clipboard operation
tools-python copied to clipboard

Add support for parsing complex license expressions

Open xavierfigueroav opened this issue 6 years ago • 6 comments

Make use of the license-expression library to parse complex license expressions in SPDX documents. Signed-off-by: Xavier Figueroa [email protected]

xavierfigueroav avatar Aug 09 '19 01:08 xavierfigueroav

@xavierfigueroav ping.... do you thing this could be rebased?

pombredanne avatar Oct 08 '19 17:10 pombredanne

@xavierfigueroav ping.... do you thing this could be rebased?

Hi, PhiIippe :) I've rebased the code.

xavierfigueroav avatar Oct 10 '19 06:10 xavierfigueroav

I am keeping this around as this will eventually be merged.

pombredanne avatar Nov 13 '21 10:11 pombredanne

@pombredanne, is this still valid? Do you know when the "eventually" you mentioned might be?

As this PR is quite massive, it will cause a lot of conflicts in the future.

armintaenzertng avatar Oct 20 '22 10:10 armintaenzertng

@armintaenzertng your call. Parsing expression is a must have IMHO.

pombredanne avatar Oct 20 '22 14:10 pombredanne

I'd like to see a rebase of this PR to get a better sense of what actually changed as the multiple merge commits make this rather incomprehensible.

@xavierfigueroav, are you willing to do this? Else I'll gladly take over from here :)

armintaenzertng avatar Oct 21 '22 09:10 armintaenzertng

Looking at the size, age and type of changes in this PR, I think the only viable course of action is to start from scratch based on current main and potentially use similar logic as in this PR (I didn't actually see the implementation details at first glance, since they are drowned in a sea of formatting changes...).

I will wait for a few days to see if anyone disagrees, then close this. The corresponding issue is https://github.com/spdx/tools-python/issues/10

nicoweidner avatar Nov 03 '22 12:11 nicoweidner

Closing this as announced earlier.

nicoweidner avatar Nov 08 '22 11:11 nicoweidner