Benedikt Franke

Results 449 comments of Benedikt Franke

/remove-lifecycle rotten Maybe this issue needs to be taken to another repository. Is https://github.com/kubernetes-incubator/external-storage the right place for it?

> fsGroupChangePolicy: "Always" The docs are not totally clear about this, but I understand that this is already the default behaviour. > By default, Kubernetes recursively changes ownership and permissions...

Nice! I will probably add the scalars package as a dependency for Lighthouse anyways, once i have it all fleshed out. There are some pretty tricky things in there that...

> an optional PSR-14 event dispatcher I would like to keep this library dependency-free. As of now, it is only coupled to PHP releases and nothing else. > One way...

Events seem like a fine way to get notified about what is happening during query execution, sure. As I said, I am open to pull requests.

I am not planning to work on this myself, but am generally open towards implementing ongoing RFCs or experimental features and would accept a pull request for this.

It is not necessary, but might be better to increase the amount of possible concurrent queries. Also, I remembered that Lighthouse already supports `@defer`. You might use https://github.com/nuwave/lighthouse/tree/master/src/Defer as inspiration...

Yeah, making `@defer` opt-in seems right. `QueryComplexity::directiveExcludesField` determines if the given field will be executed at all, given the directives placed upon it. For example, if it has `@skip(if: true)`...

It is unclear to me what exactly you would like to see changed and how to achieve it. Perhaps you can just propose a pull request?

Pagination is already a quite complex part of Lighthouse, so I am somewhat apprehensive about adding even more to it. However, I also see the value in making it easier...