laravel-db-snapshots icon indicating copy to clipboard operation
laravel-db-snapshots copied to clipboard

Copy Files From External Storage To Local Storage for Import

Open wattnpapa opened this issue 1 year ago • 1 comments

Hi i had some promblems loading Snapshots gzipped from S3. So i implementent this solution where i first copy the file to local tmp Folder.

This solution works for me quite well

wattnpapa avatar Sep 03 '24 06:09 wattnpapa

@freekmurze anything i have to do fo a merge?

wattnpapa avatar Sep 16 '24 11:09 wattnpapa

Could you rebase against main to fix the conflicts?

freekmurze avatar Dec 30 '24 11:12 freekmurze

@freekmurze I think now it looks better ?

wattnpapa avatar Dec 30 '24 13:12 wattnpapa

Please don't forget adding the proper types in your method definitions (return and parameter).

xHeaven avatar Dec 30 '24 15:12 xHeaven

~~Everywhere where you specified mixed $stream, you can actually use the resource type instead of mixed.~~

xHeaven avatar Dec 30 '24 15:12 xHeaven

@xHeaven Done i think i found no way to use resource i always get errors resource is not a valid type hint in PHP for method signatures; it’s a reserved type that can’t be used directly.

wattnpapa avatar Dec 31 '24 09:12 wattnpapa

@freekmurze anything to do for me?

wattnpapa avatar Jan 07 '25 13:01 wattnpapa

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

spatie-bot avatar Jun 16 '25 10:06 spatie-bot

@xHeaven @freekmurze

please merge

wattnpapa avatar Jul 02 '25 08:07 wattnpapa