sparkle
sparkle copied to clipboard
sparkletown
Top search bar: doesn't search among venues and thus does not even search exhibitors
you can search up "Exhibit hall", seems can search up Siemens (sponsor) which opens a modal asking to enter Exhibit hall (well -- url is wrong -- https://ohbm.sparkle.space/in/%20boothsiemenshealthineers as reported elsewhere) but you can't search up individual exhibitors (e.g. "Center for Open Neuroscience"). I think it would be nice to be able to search such folks up ;)
I assume you're referring to src/components/molecules/NavSearchBar/NavSearchBar.tsx when you say 'top search bar'?
If so, it seems to currently search by 'rooms' (eg. the 'room'/portal displayed on a partymap template) rather than 'venues' themselves (eg. the actual underlying thing that rooms/portals 'link through to'):
- https://github.com/sparkletown/sparkle/blob/staging/src/components/molecules/NavSearchBar/NavSearchBar.tsx#L69-L113
I'm not sure if there is historical/current reasoning why that is the case (though I expect it ties into our 'murky'/'blurry' division of concerns between venues/rooms, that is tech debt we need to refine in future), or any edge cases that would need to be accounted for if we made this able to search for venues directly.
That's something that @sparkletown/product may like to weigh in on.
Eg. off the top of my head, if a room is disabled/hidden/etc, then I expect we may not want to be able to find the related venue in this global search, etc.
url is wrong -- ohbm.sparkle.space/in/%20boothsiemenshealthineers as reported elsewhere
@yarikoptic Can you please link to the issue/PR that describes this problem.
https://github.com/sparkletown/sparkle/search?q=ohbm.sparkle.space%2Fin%2F%2520boothsiemenshealthineers&type=code brings me to https://github.com/sparkletown/sparkle/issues/1563 which I resolved