jwst
jwst copied to clipboard
Compile under windows
Closes # Resolves JP-nnnn
Description
This PR contains the simple changes to the C code necessary to allow the C extensions to compile under Windows. These changes swap out an indeterminate array definition with a redefinition using malloc to account for the varying size of the array for each dataset.
Checklist
- [ ] Tests
- [ ] Documentation
- [x] Change log
- [ ] Milestone
- [x] Label(s)
Codecov Report
Merging #6905 (7281c72) into master (64afee0) will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #6905 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 418 418
Lines 37343 37343
=======================================
Hits 29636 29636
Misses 7707 7707
| Flag | Coverage Δ | *Carryforward flag | |
|---|---|---|---|
| nightly | 79.34% <ø> (ø) |
Carriedforward from 64afee0 | |
| unit | 53.28% <ø> (ø) |
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 64afee0...7281c72. Read the comment docs.
Is this all it takes for this package to run on Windows? Yes, please!
Would be nice to also add the Windows CI here, to be sure.