spacedrive icon indicating copy to clipboard operation
spacedrive copied to clipboard

[ENG-200] Enter on keyboard doesn't cause modal to submit

Open spacedrive-bot opened this issue 3 years ago • 10 comments

For example in the modal for adding a new device (trigged from "Add device" on Overview page), when pressing the enter key inside the text field the modal does not get submitted. Oscar Beaumont on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

If anyone wants to take a shot at this, this issue is up for grabs. Haris on Linear

spacedrive-bot avatar Jul 12 '22 11:07 spacedrive-bot

I would like to work on this if it has not already been completed

jarrodmjack avatar Aug 11 '22 15:08 jarrodmjack

Go for it!

oscartbeaumont avatar Aug 11 '22 15:08 oscartbeaumont

I am relatively new to contributing to OS, do you know which file this would be in? If not , I will continuing searching

jarrodmjack avatar Aug 11 '22 16:08 jarrodmjack

I think we have a <Modal /> React component somewhere in ./packages/ui/.

oscartbeaumont avatar Aug 11 '22 16:08 oscartbeaumont

Thank you very much

jarrodmjack avatar Aug 11 '22 16:08 jarrodmjack

Hi @oscartbeaumont , is this issue still open? i would like to give a try

MohammedBajuaifer avatar Aug 26 '22 09:08 MohammedBajuaifer

@MohammedBajuaifer it's open!

utkubakir avatar Aug 27 '22 09:08 utkubakir

@utkubakir can you assign it to me?

MohammedBajuaifer avatar Aug 27 '22 11:08 MohammedBajuaifer

@MohammedBajuaifer Sure why not, just create a PR when your work is done and someone from our team will take a look and merge it :)

utkubakir avatar Aug 27 '22 14:08 utkubakir