server icon indicating copy to clipboard operation
server copied to clipboard

Initial Support for Spacebar WebRTC

Open CE1CECL opened this issue 1 year ago • 9 comments

please note: WebRTC was ONLY tested using a test client that was since deleted by spacebar owners, no other clients were tested, nor bot libraries were either (discord.js didn't work for me since it always requires a https connection)

NOTE: This PR DOES NOT add Screen sharing, but adds webcam support and voice ~~BREAKING CHANGES: Windows can no longer be supported after this PR is merged, because medooze-media-server doesn't support windows~~ WebRTC can now be disabled with a env var to continue support for Windows

Known bugs:

  • Muting, unmuting, deafening, and undeafening makes the voice call reconnect for unknown reason.
  • Defend does not work on test client because of the reconnect bug.
  • Video support can be buggy, requiring both cameras on to fully work (why?)
  • You tell me what other issues there are: this has been a worked on thing by Me, @MaddyUnderStars & was initially created by @SamuelScheit

CE1CECL avatar Dec 28 '23 03:12 CE1CECL

*deafen, rather than defend

TheKrafter avatar Dec 28 '23 03:12 TheKrafter

if there isn't already, there should be a way to disable webrtc from loading, because I use windows for development, and I am not switching anytime soon. either config, or at the very least an environment variable

Puyodead1 avatar Dec 28 '23 19:12 Puyodead1

Worst case you could use WSL I guess? But yeah, this is probably important, even if Windows remains a minimally supported OS.

TheArcaneBrony avatar Dec 28 '23 20:12 TheArcaneBrony

if there isn't already, there should be a way to disable webrtc from loading, because I use windows for development, and I am not switching anytime soon. either config, or at the very least an environment variable

Added but it needs testing directly on Windows, which I don't have, I have Linux.

CE1CECL avatar Dec 29 '23 18:12 CE1CECL

Worst case you could use WSL I guess? But yeah, this is probably important, even if Windows remains a minimally supported OS.

No. WSL Is NOT a option, WSL requires Hyper-v which is garbage in general,, slow, etc... WSL is more like emulation than a layer like WineHQ

CE1CECL avatar Dec 29 '23 18:12 CE1CECL

what? Wine is a stdlib overlay + bincompat layer, WSL is a full on vm (and it isnt slow either)

TheArcaneBrony avatar Dec 30 '23 13:12 TheArcaneBrony

Marked as ready since its possible to disable webrtc

CE1CECL avatar Dec 30 '23 21:12 CE1CECL