RobustToolbox
RobustToolbox copied to clipboard
Move some `EntityCoordinates` methods to `TransformSystem`
trafficstars
This PR has several miscellaneous changes for a content PR, including:
- Marks various
EntityCoordinatesmethods as obsolete and moves their logic toTransformSystem - Removes various already obsoleted &
EntityCoordinatesmethods - Adds methods to UserInterfaceSystem to get the interface data & ui range.
- Adds the
BoundUserInterfaceMessageto theBoundUserInterfaceMessageAttemptevent, so that specific interactrions/messages can be given special treatment (e.g., opening the UI). - Updates various methods in
ContainerSystemto take in optional transform components. - Changes
BoundUserInterfaceCheckRangeEventso that it only gets raised directed and not broadcast. This is just to try slightly improve performance, because doing both will just be slower.
Requires space-wizards/space-station-14/pull/27999
Is it possible to do obsoletions? I really don't want to tank breaking changes here.
Is it possible to do obsoletions? I really don't want to tank breaking changes here.
AFAIK I removed all the breaking changes, though content tests are still failing because of a new error log, but that was an existing error that just wasn't being caught before by tests.