maigret icon indicating copy to clipboard operation
maigret copied to clipboard

make graph more meaningful

Open overcuriousity opened this issue 11 months ago • 4 comments

if a search with multiple usernames is launched, it creates an additional site node where they both are found. advantages:

  • better recognition, that users have a connection with each other
  • better detection of false positives when launching a search with two fake usernames (site node = definite false positive)

overcuriousity avatar Dec 17 '24 09:12 overcuriousity

Thanks again! <3 That's a pretty big change of logic. Could you show some examples before/after?

soxoj avatar Dec 17 '24 10:12 soxoj

Sure!

Before: image

After: image

Unfortunately, I noticed that i might have broken some other logic (displaying nodes extracted by parsing?).

But the idea is, that username nodes actually have a connection across some hops if they both have an account on the same platform.

Please feel free to close PR as its currently breaking more than doing any good...

overcuriousity avatar Dec 17 '24 10:12 overcuriousity

This is quite good!

I will not close the PR, ofc - these are good changes, and they will be merged! But I want to make sure that no other logic breaks and fix it if necessary.

I’ll test everything and think about tests for the future; this will take some time 👍

soxoj avatar Dec 17 '24 10:12 soxoj

Great news, appreciate it!

overcuriousity avatar Dec 17 '24 13:12 overcuriousity

Fixed. Problem was caused by the same issue as the one resolved in #1975.

overcuriousity avatar Dec 17 '24 14:12 overcuriousity

image

overcuriousity avatar Dec 17 '24 14:12 overcuriousity