hyperterm-summon icon indicating copy to clipboard operation
hyperterm-summon copied to clipboard

Hotkey error when opening a second instance of Hyper

Open cstrnt opened this issue 7 years ago • 3 comments
trafficstars

  • [x] I am on the latest hyperterm-summon version

  • [x] I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10

  • Hyper.app version: 2.0.0

  • hyperterm-summon version: 2.0.9

  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/Frexeptabel/a8bffdcc0d8e3bbd38086a848e171d69

  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A


Issue

When you open a new instance of Hyper while already having one instance open there will be the error message "Could not register 'summon' shortcut (<Your Shortcut>)"

Steps to Reproduce

  1. Open an instance of Hyper with the summon plugin installed and setup
  2. Open a new instance of Hyper

Expected Result

There should be a list of fallback shortcuts / hotkeys when a new instance of hyper is opened. Otherwise you could add a number like 1-9 to your shortcut to access the instances. Anyway no error should be shown

Actual Result

An error is shown like described in the Issue

cstrnt avatar Jul 10 '18 08:07 cstrnt

Thanks for the report. This seems similar to #25.

  • When you say "new instance of Hyper" do you mean opening a second Hyper window?
  • Does the error occur for the first Hyper window?

dcalhoun avatar Jul 11 '18 13:07 dcalhoun

Sorry for not clarifying! When talking about "new instance" I mean a new Hyper window! And the error just occurs on the second window. I can just the shortcut for the first window like I could before. I just doesn't work on the second one (and all other new windows I would open).

I'm pretty sure that once the shortcut is registered it is applied to all windows of hyper and therefore there is an error because to windows can't use the same shortcut. But that's just my idea!

cstrnt avatar Jul 17 '18 09:07 cstrnt

Thanks for the clarification. There appears to be issues on both Windows and Linux. I run macOS and have never had an environment to debug this. I'll try to find a way to figure this out, but PR's are most definitely welcome.

dcalhoun avatar Jul 20 '18 15:07 dcalhoun