sourmash icon indicating copy to clipboard operation
sourmash copied to clipboard

Published 20 hours ago • verified publisher icon sourmash-bio

separate out load_signatures code to distinguish loading-from-file and parsing-from-string

Open ctb opened this issue 5 years ago • 3 comments

per https://github.com/dib-lab/sourmash/issues/875#issuecomment-583783495

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.

ctb avatar Jun 28 '20 14:06 ctb

punt to 5.0, I think.

ctb avatar Jan 10 '21 15:01 ctb

pretty sure this bug https://github.com/sourmash-bio/sourmash/issues/2945 is caused by the checks put in place to support loading from string.

ref:

  • https://github.com/sourmash-bio/sourmash/issues/2945

ctb avatar May 14 '24 13:05 ctb

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.

#3161 completes the task of making this a not-public function (deprecated for v5.0, removed from most internal use, and renamed to load_signatures_from_json). So we'll be in good shape for changing the behavior for the future.

ctb avatar May 14 '24 13:05 ctb