sourcery

sourcery copied to clipboard

Locations for the config file

4

### Issue description or question The [doc](https://github.com/sourcery-ai/sourcery/wiki/Sourcery-configuration#the-sourcery-configuration-file) says: > Sourcery reads configuration settings from `.sourcery.yaml` in the project directory. What this means is not very clear. Does Sourcery search for...

laike9m

### Issue description or question When posting reports as GitHub comments, any existing report is deleted and a new one posted. This is wrong since it will trigger email notifications...

casperdcl

## Description I opened a PR today (br3ndonland/inboard#43), expecting to receive a report from the Sourcery GitHub App. It didn't show up until after I merged the PR. It would...

br3ndonland

Merge repeated with statements into single with

3

### Issue description or question In unit tests of a legacy system I often come across code like: ``` with patch('...', return_value='whatever'): with patch.object(LocalObj, 'get_...', return_value=expected_data) as mocked_x: with patch('..',...

cleder

Switch refactoring always re-orders if..elif comparisons alphabetically

1

### Issue description or question The switch refactoring always re-orders comparisons of values to strings alphabetically. This does not change behaviour but can obscure developer intent and harm readability. ###...

Hellebore

Read configuration from `pyproject.toml`

1

### Issue description or question [PEP 518](https://www.python.org/dev/peps/pep-0518) introduces the `pyproject.toml` file and [recommends](https://www.python.org/dev/peps/pep-0518/#tool-table) specifying tool configuration data in the `[tool]` table. Having all configurations in one place makes it easier...

ruancomelli

Lift return into if can result in unnecessary else after return

2

### Issue description or question For the following code ``` def elapsed(self): if self.count == self.total: elapsed = self.last_update - self.start else: elapsed = time.time() - self.start return elapsed ```...

avylove

Refactor using with block misses second open()/close() set

1

### Issue description or question In the following function, Sourcery only suggests to refactor the `outfile` `open()`/`close()` set to a `with` block, but doesn't make any suggestions about the `infile`...

dericke

Unecessary None checking

3

### Issue description or question I noticed a unnecessary None checking that could be simplified: ```python from typing import List, Optional def func(items: Optional[List]): if items is not None and...

marcoaaguiar

Support for accepting / rejecting refactorings via GitHub UI

4

Right now if you have @sourcery-ai-bot installed for your GitHub repository it opens a separate PR. In this new PR it simply adds all refactorings without comments. If you let...

pmeier