loopback4-microservice-catalog icon indicating copy to clipboard operation
loopback4-microservice-catalog copied to clipboard

feat(search-service): add sequelize support in search service

Open Surbhi-sharma1 opened this issue 1 year ago • 7 comments

add sequelize support in search service

GH-1350

Description

add sequelize support in search service

Fixes #1350

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Checklist:

  • [ ] Performed a self-review of my own code
  • [ ] npm test passes on your machine
  • [ ] New tests added or existing tests modified to cover all changes
  • [ ] Code conforms with the style guide
  • [ ] API Documentation in code was updated
  • [ ] Any dependent changes have been merged and published in downstream modules

Surbhi-sharma1 avatar Jan 02 '24 15:01 Surbhi-sharma1

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
38.3% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jan 18 '24 09:01 sonarqubecloud[bot]

https://github.com/loopbackio/loopback-next/issues/10312 Raised an issue related to this PR in loopback/next sequelize extension

Surbhi-sharma1 avatar Jan 22 '24 07:01 Surbhi-sharma1

Will be merged after the sequelize version is updated in all services.

yeshamavani avatar Mar 14 '24 07:03 yeshamavani

https://github.com/sourcefuse/loopback4-microservice-catalog/pull/2047 will be merged after this PR

Surbhi-sharma1 avatar Mar 22 '24 05:03 Surbhi-sharma1

loopbackio/loopback-next#10312 Raised an issue related to this PR in loopback/next sequelize extension the above mentioned PR is merged

Surbhi-sharma1 avatar Mar 22 '24 05:03 Surbhi-sharma1

@Surbhi-sharma1 version updates are done you can rebase this PR please test your changes in loopback-sequelize are working fine once that is done we can merge this pR

yeshamavani avatar Mar 28 '24 06:03 yeshamavani