awesome-vue-3 icon indicating copy to clipboard operation
awesome-vue-3 copied to clipboard

Published 20 hours ago • verified publisher icon sonicoder86

Added vue3-easter-egg-trigger package

Open webdevnerdstuff opened this issue 2 years ago • 7 comments

webdevnerdstuff avatar Jan 26 '23 19:01 webdevnerdstuff

Project looks good. The PR includes a .history folder, can you remove that?

Jogai avatar Jan 26 '23 23:01 Jogai

I thought I skipped adding that. My bad. Do you mind if I create a .gitignore to add that directory to? And a couple other regular .gitignore items? Should prevent that in the future.

webdevnerdstuff avatar Jan 27 '23 00:01 webdevnerdstuff

First things first, I'm not a collaborator on this repo, (I confused this with the one from vuejs wher I am). But in my opinion, a .gitignore is not needed. Especially for something like .history, because that seems to be something from one specific tool.

Jogai avatar Jan 27 '23 01:01 Jogai

I add a full .gitignore file, which should help prevent multiple situations of files that should be ignored (not just .history). Doesn't hurt to have it really, but if you really want me to, I'll remove it.

webdevnerdstuff avatar Jan 27 '23 01:01 webdevnerdstuff

Once again I got confused thinking you were a collaborator. My bad.

webdevnerdstuff avatar Jan 27 '23 01:01 webdevnerdstuff

There is no code within the repository, I think it unnecessary to have a gitignore

sonicoder86 avatar Mar 23 '23 17:03 sonicoder86

I have removed the file from the commit.

webdevnerdstuff avatar Mar 23 '23 17:03 webdevnerdstuff