sonic-pi icon indicating copy to clipboard operation
sonic-pi copied to clipboard

Windows build process fails when using cmake 4

Open ethancrawford opened this issue 6 months ago • 0 comments

Several of the Windows build dependencies currently fail to compile when using cmake 4.

  • Firstly, vckpg fails to build lib-ogg as the build script for lib-ogg in the specified vcpkg branch depends on a minimum version of cmake that is no longer supported.
  • The same issue occurs for the app/api/vendor/PlatformFolders-4.2.0 package also.

In order to get the build working again for myself, it was necessary to (for example):

  • Update this line: https://github.com/sonic-pi-net/sonic-pi/blob/32cdbcb42db7bd53b4f95c350dec9d53644e5eda/app/win-pre-vcpkg.bat#L8 (changing 2025.02.14 to 2025.04.09), and

  • Update this line: https://github.com/sonic-pi-net/sonic-pi/blob/32cdbcb42db7bd53b4f95c350dec9d53644e5eda/app/win-config.bat#L19 (adding -DCMAKE_POLICY_VERSION_MINIMUM=3.10 as an extra command line argument to cmake).

PlatformFolders updated their minimum required cmake version recently as seen here: https://github.com/sago007/PlatformFolders/blob/42748e0d35d2df0a817321d6439dad7caf62a449/CMakeLists.txt#L2 ...but that is still too old for cmake 4.

Is it worth supporting cmake 4, or is that too new?

ethancrawford avatar May 09 '25 16:05 ethancrawford