sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

PVST Feature commit

Open divyachandralekha opened this issue 1 year ago • 23 comments

What I did Added config/show/debug/clear handling for STP Modified other utilities script to include STP

How I did it How to verify it

divyachandralekha avatar Oct 04 '24 05:10 divyachandralekha

/azpw run Azure.sonic-buildimage

divyachandralekha avatar Oct 23 '24 04:10 divyachandralekha

/AzurePipelines run Azure.sonic-buildimage

mssonicbld avatar Oct 23 '24 04:10 mssonicbld

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Oct 23 '24 04:10 azure-pipelines[bot]

/azpw run Azure.sonic-utilities

ridahanif96 avatar Oct 23 '24 05:10 ridahanif96

/azpw run

divyachandralekha avatar Oct 24 '24 08:10 divyachandralekha

/AzurePipelines run

mssonicbld avatar Oct 24 '24 08:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 24 '24 08:10 azure-pipelines[bot]

/azpw run

ridahanif96 avatar Oct 28 '24 10:10 ridahanif96

/azpw run

divyachandralekha avatar Oct 28 '24 11:10 divyachandralekha

/AzurePipelines run

mssonicbld avatar Oct 28 '24 11:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '24 11:10 azure-pipelines[bot]

/azpw run

divyachandralekha avatar Oct 29 '24 04:10 divyachandralekha

/AzurePipelines run

mssonicbld avatar Oct 29 '24 04:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 29 '24 04:10 azure-pipelines[bot]

/azpw run

divyachandralekha avatar Oct 29 '24 11:10 divyachandralekha

/AzurePipelines run

mssonicbld avatar Oct 29 '24 11:10 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 29 '24 11:10 azure-pipelines[bot]

@qiluo-msft please help merge this

adyeung avatar Nov 01 '24 20:11 adyeung

There few issues and fixed in our code. Will add the fixes once this is committed. Approving.

bendrapubalareddy avatar Nov 04 '24 06:11 bendrapubalareddy

In General comment for all the PVST PRs: It's good to list and attach the test results to the PRs

bendrapubalareddy avatar Nov 04 '24 06:11 bendrapubalareddy

HI @bendrapubalareddy , I have re requested by mistake, Please re approve this PR Thanks Divya

divyachandralekha avatar Nov 04 '24 07:11 divyachandralekha

Hi @divyachandralekha, can you help link a design doc in PR description if have one.

xincunli-sonic avatar Nov 04 '24 17:11 xincunli-sonic

https://github.com/sonic-net/SONiC/pull/386

adyeung avatar Nov 04 '24 18:11 adyeung

/azpw run

divyachandralekha avatar Nov 05 '24 11:11 divyachandralekha

/AzurePipelines run

mssonicbld avatar Nov 05 '24 11:11 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Nov 05 '24 11:11 azure-pipelines[bot]

@xincunli-sonic @hdwhdw I have addressed all review comments. Please approve the changes.

divyachandralekha avatar Nov 11 '24 18:11 divyachandralekha

@qiluo-msft . Please help to merge the changes.

divyachandralekha avatar Nov 12 '24 04:11 divyachandralekha

@qiluo-msft, could you please help in merging the changes? As for the comments related to JSON comparison for the show output, we will address them as part of the MSTP code merge.

divyachandralekha avatar Nov 13 '24 14:11 divyachandralekha

@yuezhoujk Please merge the changes

divyachandralekha avatar Jul 15 '25 16:07 divyachandralekha