sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Add received-bandwidth and originate-bandwidth CLI

Open colintle opened this issue 1 year ago • 1 comments

Associated PR: https://github.com/sonic-net/sonic-buildimage/pull/19532 https://github.com/sonic-net/sonic-buildimage/pull/19663 https://github.com/sonic-net/sonic-buildimage/pull/19664 https://github.com/sonic-net/sonic-buildimage/pull/19662

What I did

  • 'show bgp device-global' now works with multi-asic.
  • I created a CLI to configure W-ECMP settings on receiver devices aka received-bandwidth.
  • I created a CLI to configure W-ECMP settings to advertise bandwidth aka originate-bandwidth.

How I did it

  • I modified existing code to now include more subcommands of "config bgp device-global w-ecmp".
  • I modified the functionality for 'show bgp device-global'.
  • The CLI uses FRR to modify router configuration: router bgp -> bgp bestpath bandwidth ...

How to verify it

  • I wrote unit tests for this and tested it on a virtual testbed.
  • I tested on virtual T2-chassis with multi-asic and wrote unit tests for it.
  • I verified it by creating unit tests for it and testing it on virtual testbed T2 multi-asic.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Multi-Asic image

Single-Asic image

colintle avatar Jul 10 '24 21:07 colintle

can we be a little bit more specific in the title what's being added in this PR

rlhui avatar Jul 18 '24 19:07 rlhui