sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

kdump-Remote-SSH-Configurations

Open Ghulam-Bahoo opened this issue 1 year ago • 3 comments

What I did Added remote kdump functionality using SSH in SONiC.

How I did it I added two new commands and two options to configure the kdump remote ssh feature.

How to verify it Upon kernel crash, kdump will transfer the crash report files to the ssh server.

Ghulam-Bahoo avatar Jul 04 '24 07:07 Ghulam-Bahoo

@venkatmahalingam can you please help review this PR?

Ghulam-Bahoo avatar Jul 31 '24 07:07 Ghulam-Bahoo

@venkatmahalingam Hi! we have updated the code. Please Help us review the Code PRs. Thanks

muhammadalihussnain avatar Oct 02 '24 05:10 muhammadalihussnain

@venkatmahalingam Hi! we have updated the code. Please Help us review the Code PRs. Thanks in advance, target is 202411

ridahanif96 avatar Oct 28 '24 10:10 ridahanif96

Hi @qiluo-msft , please review to merge this PR

wajahatrazi avatar Dec 04 '24 07:12 wajahatrazi

Hi @qiluo-msft / @lguohan

PR has been reviewed by the reviewer with all checks passed, please help merge this.

wajahatrazi avatar Dec 10 '24 07:12 wajahatrazi

@qiluo-msft help merge this PR, pending for long

ridahanif96 avatar Dec 14 '24 20:12 ridahanif96

@qiluo-msft this PR has been approved by reviewers and can you please help to check if you are ok to merge? Thanks.

zhangyanzhao avatar Jan 21 '25 03:01 zhangyanzhao

@qiluo-msft this PR has been approved by reviewers and can you please help to merge? Thanks.

muhammadalihussnain avatar Feb 05 '25 10:02 muhammadalihussnain

@qiluo-msft this PR has been approved by reviewers and can you please help to merge? Thanks.

muhammadalihussnain avatar Feb 20 '25 12:02 muhammadalihussnain

/azp run

mssonicbld avatar Mar 20 '25 06:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '25 06:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 20 '25 06:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '25 06:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 20 '25 07:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '25 07:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 20 '25 08:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '25 08:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 20 '25 09:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 20 '25 09:03 azure-pipelines[bot]

/azp run

mssonicbld avatar Mar 21 '25 05:03 mssonicbld

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Mar 21 '25 05:03 azure-pipelines[bot]

@qiluo-msft this PR has been approved by reviewers and can you please help to merge? Thanks.

muhammadalihussnain avatar Mar 24 '25 05:03 muhammadalihussnain

hi @Ghulam-Bahoo, we are seeing some issues with this change. Several buildimage pipeline runs are failing because of errors like the following:

E 2025 Apr 1 04:56:08.321576 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--disable'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:09.638838 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--memory', '0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:11.199498 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--num_dumps', '3'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:13.969595 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--remote', 'false'] - failed: return code - 2, output:#012None
E 2025 Apr 1 04:56:16.373762 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--ssh_string', 'user@localhost'] - failed: return code - 1, output:#012None
E 2025 Apr 1 04:56:17.579657 vlab-02 ERR hostcfgd: ['sonic-kdump-config', '--ssh_path', '/a/b/c'] - failed: return code - 1, output:#012None

@arista-nwolfe did some debugging on this and found out that you are using options.remote without adding that option.

parser.add_argument('--ssh_string', nargs='?', type=str, action='store', default=False,
        help='ssh_string for remote kdump')

parser.add_argument('--ssh_path', nargs='?', type=str, action='store',default=False,
        help='ssh_path for remote kdump')

Could you please help fix this asap?

@judyjoseph for viz.

prabhataravind avatar Apr 03 '25 02:04 prabhataravind