sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Switchport Mode & CLI Modified Fix

Open sabakram opened this issue 1 year ago • 12 comments

What I did

This PR is Fixture for https://github.com/sonic-net/sonic-utilities/pull/3108 The PR was reverted due to backward compatibility issues. As per new suggestions, removed db migrator changes from this new change along with vlan.py & switchport.py changes

To Fix issues as per suggestions removed default mode from YANG model and removed minigraph changes:

How I did it

   1. Removed Db migrator changes from code. 
   2. Modified Vlan.py & Switchport.py changes 

How to verify it

New commands have been added in Command-Reference.md All the syntax and examples have been added there and they can be verified by running the specific command

sabakram avatar Mar 28 '24 19:03 sabakram

Hi @wen587, can you please review this PR. This is in reference to PR.

We have modified code. We removed Db-migrator changes along with updated vlan.py & switchport.py to remove default "routed" mode behavior.

sabakram avatar Apr 02 '24 09:04 sabakram

Hi @theasianpianist , @prsunny @venkatmahalingam can you please help review this PR.

ridahanif96 avatar Apr 03 '24 06:04 ridahanif96

Hi @theasianpianist , @prsunny @venkatmahalingam can you please help review this PR.

Hi All,

Can you help with review this PR. Thanks.

ridahanif96 avatar Apr 07 '24 19:04 ridahanif96

Hi @prsunny & @venkatmahalingam , can you please help with review. Thanks in advance,

ridahanif96 avatar Apr 09 '24 04:04 ridahanif96

Can you please confirm there is no changes to existing 'show' commands? I see there is a new show CLI command which is ok.

prsunny avatar Apr 10 '24 22:04 prsunny

Please confirm, this issue is fixed in this PR - https://github.com/sonic-net/sonic-buildimage/issues/18392

prsunny avatar Apr 10 '24 23:04 prsunny

Can you please confirm there is no changes to existing 'show' commands? I see there is a new show CLI command which is ok.

Hi @prsunny , we didn't make any change in exisiting show commands i.e in "show vlan brief" & "show int status". We proposed new show commands for switchport mode i.e "show int switchport config" & "show int switchport status"

sabakram avatar Apr 11 '24 15:04 sabakram

Please confirm, this issue is fixed in this PR - sonic-net/sonic-buildimage#18392

Yes, We have checked this change with latest build. Please see behavior ShowVersion Cffgen_2 Cffgen_l2 Portchannel

sabakram avatar Apr 11 '24 15:04 sabakram

Hi @wen587 Do you also suggest change for this PR in sonic_mgmt/gcu/test_vlan.py?

sabakram avatar Apr 11 '24 15:04 sabakram

@venkatmahalingam Hi Venkat, can you pls help review this PR.

ridahanif96 avatar Apr 11 '24 18:04 ridahanif96

/azp run Azure.sonic-utilities #Closed

qiluo-msft avatar Apr 16 '24 00:04 qiluo-msft

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Apr 16 '24 00:04 azure-pipelines[bot]

No pipelines are associated with this pull request.

azure-pipelines[bot] avatar Apr 22 '24 22:04 azure-pipelines[bot]

Waiting on @prsunny approval.

qiluo-msft avatar May 09 '24 18:05 qiluo-msft