sonic-utilities
sonic-utilities copied to clipboard
Switchport Mode & CLI Modified Fix
What I did
This PR is Fixture for https://github.com/sonic-net/sonic-utilities/pull/3108 The PR was reverted due to backward compatibility issues. As per new suggestions, removed db migrator changes from this new change along with vlan.py & switchport.py changes
To Fix issues as per suggestions removed default mode from YANG model and removed minigraph changes:
How I did it
1. Removed Db migrator changes from code.
2. Modified Vlan.py & Switchport.py changes
How to verify it
New commands have been added in Command-Reference.md All the syntax and examples have been added there and they can be verified by running the specific command
Hi @wen587, can you please review this PR. This is in reference to PR.
We have modified code. We removed Db-migrator changes along with updated vlan.py & switchport.py to remove default "routed" mode behavior.
Hi @theasianpianist , @prsunny @venkatmahalingam can you please help review this PR.
Hi @theasianpianist , @prsunny @venkatmahalingam can you please help review this PR.
Hi All,
Can you help with review this PR. Thanks.
Hi @prsunny & @venkatmahalingam , can you please help with review. Thanks in advance,
Can you please confirm there is no changes to existing 'show' commands? I see there is a new show CLI command which is ok.
Please confirm, this issue is fixed in this PR - https://github.com/sonic-net/sonic-buildimage/issues/18392
Can you please confirm there is no changes to existing 'show' commands? I see there is a new show CLI command which is ok.
Hi @prsunny , we didn't make any change in exisiting show commands i.e in "show vlan brief" & "show int status". We proposed new show commands for switchport mode i.e "show int switchport config" & "show int switchport status"
Please confirm, this issue is fixed in this PR - sonic-net/sonic-buildimage#18392
Yes, We have checked this change with latest build. Please see behavior
Hi @wen587 Do you also suggest change for this PR in sonic_mgmt/gcu/test_vlan.py?
@venkatmahalingam Hi Venkat, can you pls help review this PR.
/azp run Azure.sonic-utilities #Closed
Azure Pipelines successfully started running 1 pipeline(s).
No pipelines are associated with this pull request.
Waiting on @prsunny approval.