sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

show interfaces transceiver eeprom -d reports an error

Open Alicia-Zhu opened this issue 1 year ago • 0 comments

Description

https://github.com/sonic-net/sonic-utilities/blob/6e4130d8e2f95094f8f294206a0578b0babb354e/utilities_common/sfp_helper.py#L36C1-L37C46

    'active_firmware': 'Active Firmware',
    'inactive_firmware': 'Inactive Firmware',

The above two lines of code need to be deleted, otherwise running the 'show interfaces transceiver eeprom -d' command will result in an error.

Steps to reproduce the issue:

1.show interfaces transceiver eeprom -d

Describe the results you received:

root@M2-W6930:/home/admin# show interfaces  transceiver  eeprom -d
Traceback (most recent call last):
  File "/usr/local/bin/sfpshow", line 727, in <module>
    cli()
  File "/usr/local/lib/python3.11/dist-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/dist-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/sfpshow", line 651, in eeprom
    sfp.get_eeprom()
  File "/usr/local/lib/python3.11/dist-packages/utilities_common/multi_asic.py", line 157, in wrapped_run_on_all_asics
    func(self,  *args, **kwargs)
  File "/usr/local/bin/sfpshow", line 557, in get_eeprom
    self.intf_eeprom[interface] = self.convert_interface_sfp_info_to_cli_output_string(
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/sfpshow", line 454, in convert_interface_sfp_info_to_cli_output_string
    sfp_info_output = self.convert_sfp_info_to_output_string(sfp_info_dict)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/bin/sfpshow", line 342, in convert_sfp_info_to_output_string
    output += '{}{}: {}\n'.format(indent, data_map[key], sfp_info_dict[key])
                                                         ~~~~~~~~~~~~~^^^^^
KeyError: 'active_firmware'

Describe the results you expected:

The command can successfully obtain module information.

Output of show version:

root@sonic:/home/admin# show version 

SONiC Software Version: SONiC.master-16148.481924-d57b61f55
SONiC OS Version: 12
Distribution: Debian 12.4
Kernel: 6.1.0-11-2-amd64
Build commit: d57b61f55
Build date: Tue Feb 20 12:35:00 UTC 2024
Built by: AzDevOps@vmss-soni0034BK

Platform: x86_64-micas_m2-w6930-64qc-r0
HwSKU: M2-W6930-64QC
ASIC: broadcom
ASIC Count: 1
Serial Number: G1SA10J000485
Model Number: 01019AQ0
Hardware Revision: 100
Uptime: 03:17:16 up  1:43,  2 users,  load average: 0.47, 0.55, 0.65
Date: Thu 22 Feb 2024 03:17:16

Docker images:
REPOSITORY                    TAG                             IMAGE ID       SIZE
docker-sonic-restapi          latest                          afdd4da78b93   302MB
docker-sonic-restapi          master-16148.481924-d57b61f55   afdd4da78b93   302MB
docker-dhcp-relay             latest                          06cd0e458dce   312MB
docker-macsec                 latest                          92bd8c8d64c6   333MB
docker-eventd                 latest                          0df7d6b6a414   302MB
docker-eventd                 master-16148.481924-d57b61f55   0df7d6b6a414   302MB
docker-orchagent              latest                          b4eb005e0ec3   342MB
docker-orchagent              master-16148.481924-d57b61f55   b4eb005e0ec3   342MB
docker-sflow                  latest                          34b53a8347f7   332MB
docker-sflow                  master-16148.481924-d57b61f55   34b53a8347f7   332MB
docker-teamd                  latest                          ee1fb392c093   331MB
docker-teamd                  master-16148.481924-d57b61f55   ee1fb392c093   331MB
docker-snmp                   latest                          a05455b052ae   342MB
docker-snmp                   master-16148.481924-d57b61f55   a05455b052ae   342MB
docker-fpm-frr                latest                          e79b8bf88727   362MB
docker-fpm-frr                master-16148.481924-d57b61f55   e79b8bf88727   362MB
docker-syncd-brcm             latest                          1b336146b1f5   716MB
docker-syncd-brcm             master-16148.481924-d57b61f55   1b336146b1f5   716MB
docker-nat                    latest                          ee314c97b57c   333MB
docker-nat                    master-16148.481924-d57b61f55   ee314c97b57c   333MB
docker-platform-monitor       latest                          7b13508eaf0d   424MB
docker-platform-monitor       master-16148.481924-d57b61f55   7b13508eaf0d   424MB
docker-sonic-gnmi             latest                          1991af4ae3e5   391MB
docker-sonic-gnmi             master-16148.481924-d57b61f55   1991af4ae3e5   391MB
docker-router-advertiser      latest                          79194e56b6c9   303MB
docker-router-advertiser      master-16148.481924-d57b61f55   79194e56b6c9   303MB
docker-lldp                   latest                          eb4c39e5cb20   345MB
docker-lldp                   master-16148.481924-d57b61f55   eb4c39e5cb20   345MB
docker-gbsyncd-broncos        latest                          27a2b3e3b7c9   353MB
docker-gbsyncd-broncos        master-16148.481924-d57b61f55   27a2b3e3b7c9   353MB
docker-database               latest                          c3fd1c0690f9   312MB
docker-database               master-16148.481924-d57b61f55   c3fd1c0690f9   312MB
docker-mux                    latest                          41072c53d6ca   351MB
docker-mux                    master-16148.481924-d57b61f55   41072c53d6ca   351MB
docker-gbsyncd-credo          latest                          d6ae0c59f46a   325MB
docker-gbsyncd-credo          master-16148.481924-d57b61f55   d6ae0c59f46a   325MB
docker-sonic-mgmt-framework   latest                          c5958fb546ea   387MB
docker-sonic-mgmt-framework   master-16148.481924-d57b61f55   c5958fb546ea   387MB

Output of show techsupport:

Uploading sonic_dump_M2-W6930_20240222_084815.tar.gz…

Additional information you deem important (e.g. issue happens only occasionally):

Alicia-Zhu avatar Feb 23 '24 08:02 Alicia-Zhu