sonic-utilities
sonic-utilities copied to clipboard
sonic-net
Add CLIs to support TWAMP Light
What I did
Add CLIs support TWAMP Light feature according to HLD sonic-net/SONiC#1320
How I did it
- Add config command to config twamp-light
- Add show command to show twamp-light session
How to verify it
Manual test.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
admin@sonic:~$ sudo config twamp-light session-sender packet-count add snd_1 36.1.1.1 36.1.1.2 1000 10 10 11000
admin@sonic:~$ sudo config twamp-light session-sender continuous add snd_1 22.1.1.1 22.1.1.2 60 100 10 20000
admin@sonic:~$ sudo config twamp-light session-reflector add ref_1 22.1.1.1 22.1.1.2
admin@sonic:~$
admin@sonic:~$ show twamp-light session
Time unit: Monitor Time/Timeout in second; Tx Interval/Stats Interval in millisecond
TWAMP-Light Sender Sessions
Name Status Sender IP:PORT Reflector IP:PORT Packet Count Monitor Time Tx Interval Stats Interval Timeout
------- -------- ---------------- ------------------- -------------- -------------- ------------- ---------------- ---------
snd_1 inactive 36.1.1.1:862 36.1.1.2:863 1000 - 10 11000 10
snd_2 inactive 22.1.1.1:862 22.1.1.2:863 - 60 100 20000 10
TWAMP-Light Reflector Sessions
Name Status Sender IP:PORT Reflector IP:PORT
------ -------- ---------------- -------------------
ref_1 active 22.1.1.1:862 22.1.1.2:863
admin@sonic:~$
admin@sonic:~$ sudo config twamp-light session-sender start all
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-loss
Latest two-way loss statistics:
Name Index Loss Count Loss Ratio
------- ------- ------------ ------------
snd_1 1 0 0
2 0 0
3 0 0
4 0 0
5 0 0
6 0 0
7 0 0
8 0 0
9 0 0
10 0 0
snd_2 1 0 0
2 0 0
3 0 0
Total two-way loss statistics:
Name Loss Count(AVG) Loss Count(MIN) Loss Count(MAX) Loss Ratio(AVG) Loss Ratio(MIN) Loss Ratio(MAX)
------- ----------------- ----------------- ----------------- ----------------- ----------------- -----------------
snd_1 0 0 0 0 0 0
snd_2 0 0 0 0 0 0
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-delay
Latest two-way delay statistics(nsec):
Name Index Delay(AVG) Jitter(AVG)
------- ------- ------------ -------------
snd_1 1 1761 0
2 1758 0
3 1761 0
4 1761 0
5 1761 0
6 1758 0
7 1759 0
8 1758 0
9 1759 0
10 1760 0
snd_2 1 3983 1
2 3984 1
3 3987 1
Total two-way delay statistics(nsec):
Name Delay(AVG) Delay(MIN) Delay(MAX) Jitter(AVG) Jitter(MIN) Jitter(MAX)
------- ------------ ------------ ------------ ------------- ------------- -------------
snd_1 1759 1691 1825 0 0 3
snd_2 3985 3896 4097 0 0 5
admin@sonic:~$
@qiluo-msft @yxieca @StormLiangMS @prsunny could you please help to review this PR? Thanks. This feature is tracked for 202311 release and the HLD link is : https://github.com/sonic-net/SONiC/pull/1320 @zhangyanzhao
Hi @maipbui, TWAMP Light is for SONiC 202405 Release and https://github.com/sonic-net/SONiC/pull/1320 other submodules is already merged into master. Please help to review and approve it or assign someone on behalf of you. Thank you very much.
@qiluo-msft Please help to review this MR and approve to merge it. It is important for TWAMP Light release in SONiC 202405. Thanks very much.
This PR is the last one to be merged in the TWAMP light Phase1 release， could you please help to review and merge this PR， @qiluo-msft @yxieca @StormLiangMS @prsunny @prgeor， Thanks very much.
| Repo | PR title | State |
|---|---|---|
| sonic-swss | TWAMP Light orchagent implementation | |
| sonic-swss-common | Added TWAMP Light table to schema | |
| sonic-sairedis | Support TWAMP Light notification in syncd | |
| sonic-utilities | Added CLIs to support TWAMP Light | |
| SAI | Added TWAMP Light API |
@qiluo-msft @oleksandrivantsiv can you please help to review and merge this PR if you are ok? This is the last open code PR for this feature? Thanks.
@sonic-utilities-maintainer could you please help to review?
Thank you for sending the review & merge request. Please help to review & merge this PR, @qiluo-msft @oleksandrivantsiv @zhangyanzhao . Thanks very much.
Alibaba is the registered reviewer. @eddieruan-alibaba can you please find someone from Alibaba to review this PR? Thanks.
@eddieruan-alibaba @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @prgeor @clarklee-guizhao Please help to review & merge this PR . Thanks very much.
I have asked Shuanghong from my team to review it. We are using software twamp
I have asked Shuanghong from my team to review it. We are using software twamp
Thank you very much for reviewing. The TWAMP light HLD has considered both software and hardware-based TWAMP light solutions, and the implementation in SONiC utility here is unified. We will contribute the software implementation to the community later, and hope your team can help review it at that time, Thanks.
@eddieruan-alibaba @goomadao @zhangyanzhao I have rebased this PR to latest master branch, Please help to review & merge this PR . Thanks very much.
@eddieruan-alibaba @goomadao @zhangyanzhao @qiluo-msft , Please help to review & merge this PR, it's expect to be merged into 202411. Thanks very much.
Thank you for reviewing and approving this PR, @goomadao. Would you please help to merge this PR, @eddieruan-alibaba @qiluo-msft @oleksandrivantsiv @zhangyanzhao Thanks a lot.
Please help to merge this PR, @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao Thanks a lot
All pipelines have been passed and goomadao have been finied his review, please help to merge this PR, @liat-grozovik @abdosi @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao Thanks very much.
This PR has already reviewed and approved by Shuanghong from Alibaba team. Now it needs a repro reviewer's approval.