sonic-utilities
sonic-utilities copied to clipboard
sonic-net
Fix for GCU function modification for HEAD PR
What I did
This PR is created to resolve submodule HEAD PR KVM t0 Elastic failure issues. KVM Elastic test cases are failing due to missing mode attribute in configuration. When a rollback checks an exisitng patch it showns error: "All keys are not parsed in PORT". "dict_keys(['Ethernet4'])" "exceptionList: [" 'mode' "]
This PR Updated GCU function so that it can be compatible with HEAD PR and passed. This proposed change is a temporary solution to pass failing testcases and it will be reverted back once in hand issue is resolved and sub-modules are added in HEAD.
How I did it
Modified generic_updater.py. Added a logic in def replace function such that it will not fail in rollback. In this way it will pass KVM Elastic (GCU_Dhcp_relay.py test)
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: sabakram / name: Saba Akram (88eb0581c9ce5804c08e0627be259251be935b8c, 990973fbd6ac2e1d7ea85683b35af9adfd18c382, 5e8cd03e66828f86139a5a12088d710cc008fd87, 44ef3d8b2a267c078d65477035976788d802b2b9)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@yejianquan , I think you were helping @ridahanif96 on this submodule head PR failure. Please check if this is what would "fix" the issue?
Also tagged @qiluo-msft to help review and what this PR is trying to do is acceptable...
@yejianquan , I think you were helping @ridahanif96 on this submodule head PR failure. Please check if this is what would "fix" the issue?
Also tagged @qiluo-msft to help review and what this PR is trying to do is acceptable...
@gechiang thanks!
@yejianquan , I think you were helping @ridahanif96 on this submodule head PR failure. Please check if this is what would "fix" the issue? Also tagged @qiluo-msft to help review and what this PR is trying to do is acceptable...
@gechiang , In sonic-mgmt repo, Rida had made the compatible change, but I'm still not sure whether this PR could resolve the advancing issue totally since there's implicitly data format things...
I left some comments on the code style side, still need @qiluo-msft to help review for make sure whether 'what this PR is trying to do is acceptable'.
@yejianquan , I think you were helping @ridahanif96 on this submodule head PR failure. Please check if this is what would "fix" the issue? Also tagged @qiluo-msft to help review and what this PR is trying to do is acceptable...
@gechiang , In sonic-mgmt repo, Rida had made the compatible change, but I'm still not sure whether this PR could resolve the advancing issue totally since there's implicitly data format things...
I left some comments on the code style side, still need @qiluo-msft to help review for make sure whether 'what this PR is trying to do is acceptable'.
@yejianquan all of your suggestions are incorportated,thanks. @qiluo-msft can you please help in review this PR, so we can resolve HEAD PR issue, thanks.
@qiluo-msft , can you please help review this PR? Its a time sensitive issue for HEAD PR.
The root issue is PORT/mode is not yang modelled. I see open PR https://github.com/sonic-net/sonic-buildimage/pull/13580.
