sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

Published 20 hours ago • verified publisher icon sonic-net

[show] Added alias interface mode support for 'show interfaces counters ...' command

Open puffc opened this issue 3 years ago • 1 comments

Fixes #2464

Signed-off-by: Julian Chang - TW [email protected]

What I did

This change fixed "show interfaces counters xxx" output nothing when naming mode is alias.

How I did it

Convert the alias name into interface name for "show interfaces counters -u xxx", "show interfaces counters detailed xxx" and "show interfaces counters rif xxx" subcommands.

How to verify it

  1. Set interface naming mode to alias.
  2. Logout/Login.
  3. Verify "show interfaces counters -i Eth1".
  4. Verify "show interfaces counters rif Eth1".
  5. Verify "show interfaces counters detailed Eth1".
  6. Set interface naming mode to default.
  7. Logout/Login
  8. Repeat step 3~5.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

puffc avatar Nov 02 '22 07:11 puffc

@prsunny @yxieca Would you please review this PR? Thanks!

puffc avatar Nov 03 '22 00:11 puffc

@zjswhhh Would you please review my PR? Thanks!

puffc avatar Nov 15 '22 06:11 puffc

Is there any expert can help to review this PR?

puffc avatar Dec 14 '22 12:12 puffc

Actually the software test team of my company found many "alias naming mode" related problems. We don't know whether we should fix them one by one or just ask them to skip "alias naming mode" related testing....

puffc avatar Dec 14 '22 12:12 puffc

lgtm

Thanks for your time, @zjswhhh. Should I invite more reviewers to get this commit merged?

Julian

puffc avatar Dec 19 '22 09:12 puffc