sonic-utilities
sonic-utilities copied to clipboard
[sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)
What I did
- Checking that the running image is switched or not after CDB_run during firmware upgrade process.
How I did it
- Call api.get_module_fw_info() for checking the running and committed image are difference.
How to verify it
- Run sfputil firmware upgrade with transceivers of different vendor.
@CliveNi Could you please upload UT logs?.
@CliveNi Could you please upload UT logs?.
Adding unit test for new function, disabling a test condition in commit due to it will spend around 1min, it is enabled when capturing log. This disabled condition will reduce around 10% coverage. Is it needed to cover the "NotImplementedError" exception? It will cause coverage less than threshold.
Some environment issues cause 2 unrelated functions failure in attached UT log, it still exists even if checkout to master in my environment. sfputil_test-results.txt
@prgeor Could you please review this PR?..
@yxieca please cherry pick to 202205 @StormLiangMS please cherry pick to 202211