sonic-utilities icon indicating copy to clipboard operation
sonic-utilities copied to clipboard

[sfputil] Firmware download/upgrade CLI support for QSFP-DD (#1947)

Open CliveNi opened this issue 3 years ago • 3 comments

What I did

  • Checking that the running image is switched or not after CDB_run during firmware upgrade process.

How I did it

  • Call api.get_module_fw_info() for checking the running and committed image are difference.

How to verify it

  • Run sfputil firmware upgrade with transceivers of different vendor.

CliveNi avatar Sep 02 '22 12:09 CliveNi

@CliveNi Could you please upload UT logs?.

aravindmani-1 avatar Sep 02 '22 14:09 aravindmani-1

@CliveNi Could you please upload UT logs?.

Adding unit test for new function, disabling a test condition in commit due to it will spend around 1min, it is enabled when capturing log. This disabled condition will reduce around 10% coverage. Is it needed to cover the "NotImplementedError" exception? It will cause coverage less than threshold.

Some environment issues cause 2 unrelated functions failure in attached UT log, it still exists even if checkout to master in my environment. sfputil_test-results.txt

CliveNi avatar Sep 07 '22 12:09 CliveNi

@prgeor Could you please review this PR?..

aravindmani-1 avatar Sep 20 '22 11:09 aravindmani-1

@yxieca please cherry pick to 202205 @StormLiangMS please cherry pick to 202211

prgeor avatar Feb 08 '23 16:02 prgeor