sonic-utilities
sonic-utilities copied to clipboard
sonic-net
[kdump] Fix API to read the current running image
What I did
Simplify the API used to get the current active image name.
How I did it
Instead of relying on the output of the "sonic-installer list" command, use the API get_current_image() from the sonic_installer.bootloader py library.
How to verify it
config reload config kdump disable config kdump enable config kdump memory 768M
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
@rajendra-dendukuri could you please refer to the comment and see if this can be handled? also, please add test to cover the code changes as there is a coverage checker error.
It would be good to add unit test to increase coverage
I started to look at how test coverage can be added to these commands. Any suggestions would be of great help.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: rajendra-dendukuri (d4068c975d21d9b7a34e613b3056eeab52df0795, 81f4579ebea5e73a8e0875aec171bdde3ddc86f9, d3c96ebf52cedb0f304ca9e90adc417fafb25c2a, 2fdfaf7e30f215429e95743ff75a143805002a42)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
@rajendra-dendukuri could you please take care of the comments provided and align with the code coverage requirement?
@rajendra-dendukuri kindly reminder on the code coverage part @ayurkiv-nvda can you please review following your comment?
@rajendra-dendukuri any update on when this PR can be ready for merge?
@rajendra-dendukuri will you be able to cont the investigation and provide a fix for the coverage part? if not, they will not be merged :-(
@qiluo-msft review comments have been fixed , would you please take a look?
Hi @StormLiangMS it's a fix to https://github.com/sonic-net/sonic-buildimage/issues/11007, not only an Enhancement.