visitor-flutter icon indicating copy to clipboard operation
visitor-flutter copied to clipboard

Double follow on redeeming an invite by an already followed feed

Open irisdelaluna opened this issue 5 years ago • 3 comments

To reproduce:

  1. create new identity;
  2. start server fresh;
  3. follow feed A;
  4. generate an invite with sbotcli call invite.create;
  5. send that invite to the owner of feed A, let it be redeemed.
  6. see two follow messages on your feed, feed A is being followed twice.

irisdelaluna avatar Jun 26 '20 17:06 irisdelaluna

Which client used the invite in this case?

cryptix avatar Jun 26 '20 18:06 cryptix

@cryptix Patchwork

irisdelaluna avatar Jul 01 '20 20:07 irisdelaluna

I see, okay. I think there is retry logic if something goes wrong in patchwork. Ideally there should be more e2e scenarios in the tests folder of this implementation. Testing against ssb-server would be enough, no need to boot patchwork.

To stop the double follows you could add a graph lookup here.

cryptix avatar Jul 02 '20 08:07 cryptix