gloo icon indicating copy to clipboard operation
gloo copied to clipboard

Add VirtualHostOptions e2e tests

Open jbohanon opened this issue 1 year ago • 2 comments

Description

Please include a high level summary of the changes.

This bug fixes ... \ This new feature can be used to ...

Fill out any of the following sections that are relevant and remove the others

API changes

  • Added x field to y resource
  • ...

Code changes

  • Fix error in Foo() function
  • Add Bar() function
  • ...

CI changes

  • Adjusted schedule for x job
  • ...

Docs changes

  • Added guide about feature x to public docs
  • Updated README to account for y behavior
  • ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

See slack conversation here

Interesting decisions

We chose to do things this way because ...

Testing steps

I manually verified behavior by ...

Notes for reviewers

Be sure to verify intended behavior by ...

Please proofread comments on ...

This is a complex PR and may require a huddle to discuss ...

Checklist:

  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

BOT NOTES: resolves https://github.com/solo-io/solo-projects/issues/6085

jbohanon avatar May 02 '24 19:05 jbohanon

Visit the preview URL for this PR (updated for commit fdbac66):

https://gloo-edge--pr9434-jbohanon-vhopts-stat-prhlhm7p.web.app

(expires Wed, 15 May 2024 15:48:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

github-actions[bot] avatar May 02 '24 19:05 github-actions[bot]

Issues linked to changelog: https://github.com/solo-io/solo-projects/issues/6085

solo-changelog-bot[bot] avatar May 03 '24 14:05 solo-changelog-bot[bot]

^bulldozer has been finicky, so hoping enabling auto-merge will help

sam-heilbron avatar May 08 '24 15:05 sam-heilbron