gloo icon indicating copy to clipboard operation
gloo copied to clipboard

add_additionalLabels_to_chart

Open TheCubicleJockey opened this issue 1 year ago • 10 comments

Description

This new feature is to add additionalLabels to helm chart

Context

See issue here

Testing steps

I manually verified behavior by templating the helm chart with different values

Checklist:

  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] I have added tests that prove my fix is effective or that my feature works

TheCubicleJockey avatar Feb 26 '24 20:02 TheCubicleJockey

Waiting for approval from someone in the solo-io org to start testing.

solo-build-bot[bot] avatar Feb 26 '24 20:02 solo-build-bot[bot]

/kick

davidjumani avatar Apr 09 '24 16:04 davidjumani

@TheCubicleJockey Can you please rebase and fix the conflicts as well as revert all occurrences of gloo: gloo that have been removed

davidjumani avatar Apr 17 '24 14:04 davidjumani

Issues linked to changelog: https://github.com/solo-io/gloo/issues/9408

solo-changelog-bot[bot] avatar Apr 26 '24 19:04 solo-changelog-bot[bot]

Issues linked to changelog: https://github.com/solo-io/gloo/issues/9035

solo-changelog-bot[bot] avatar Apr 26 '24 19:04 solo-changelog-bot[bot]

/kick

davidjumani avatar Apr 26 '24 19:04 davidjumani

/kick

davidjumani avatar Apr 26 '24 19:04 davidjumani

/kick

davidjumani avatar Apr 29 '24 00:04 davidjumani

Moving this to draft until the enterprise changes are addressed

davidjumani avatar Apr 30 '24 17:04 davidjumani

Please let me know what needs done to get this moved over the line. My client (your enterprise client) is wanting this merged.

TheCubicleJockey avatar May 09 '24 14:05 TheCubicleJockey

Hi @TheCubicleJockey I'm continuing this in a new PR for faster development

davidjumani avatar May 15 '24 22:05 davidjumani