gloo icon indicating copy to clipboard operation
gloo copied to clipboard

Labeled selectors

Open jackstine opened this issue 3 years ago • 3 comments

Description

Adding in namespace selectors to Gloo. This is built off this PR in Solo-Kit..

Still have some concerns around the commented code below, will be looking into this soon.

TODO: get rid of changes to install/test/helm_suite_test.go.

Context

Users want to be able to reduce the number of resources that they are currently watching and using within their Gloo Cluster. This will allow them to reduce the scope of resources used in Gloo by adding a label and the selector filters for said labels. Only resources from namespaces that contain the labels will be used, in addition the watchedNamespaces will also be used as well.

Checklist:

  • [ ] I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • [ ] If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • [ ] I followed guidelines laid out in the Gloo Edge contribution guide
  • [ ] I opened a draft PR or added the work in progress label if my PR is not ready for review
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

jackstine avatar Sep 06 '22 18:09 jackstine

Issues linked to changelog: https://github.com/solo-io/gloo/issues/5868

solo-changelog-bot[bot] avatar Sep 20 '22 03:09 solo-changelog-bot[bot]

Visit the preview URL for this PR (updated for commit d7568c9):

https://gloo-edge--pr7097-labeledselectors-r80lkw5k.web.app

(expires Thu, 29 Sep 2022 21:58:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Sep 20 '22 03:09 github-actions[bot]

/kick

jackstine avatar Sep 22 '22 15:09 jackstine

@jackstine Can we close this PR, and if we want to keep the code around just leave the branch?

sam-heilbron avatar May 18 '23 13:05 sam-heilbron