gloo icon indicating copy to clipboard operation
gloo copied to clipboard

[WIP}Rewrite hosts in mesh

Open elcasteel opened this issue 3 years ago • 2 comments

Description

This change adds a new route action plugin that runs when istio integration is enabled. It looks at the destination for routes and if they are kubernetes services, rewrites the host to be servicename.namespace and sets the x-forwarded-host header.

It also bumps the dependency for envoyproxy go-control-plane which also resulted in bumping a version for protoc-gen-validate and changed a lot of generated files. I might separate these two changes to make the PRs easier to read.

TODO: Set of istio integration tests.

This bug fixes ... \ This new feature can be used to ...

Context

Users ran into this bug doing ... \ Users needed this feature to ...

Checklist:

  • [ ] I included a concise, user-facing changelog (for details, see https://github.com/solo-io/go-utils/tree/master/changelogutils) which references the issue that is resolved.
  • [ ] If I updated APIs (our protos) or helm values, I ran make -B install-go-tools generated-code to ensure there will be no code diff
  • [ ] I followed guidelines laid out in the Gloo Edge contribution guide
  • [ ] I opened a draft PR or added the work in progress label if my PR is not ready for review
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have added tests that prove my fix is effective or that my feature works

BOT NOTES: resolves https://github.com/solo-io/gloo/issues/6538

elcasteel avatar Aug 05 '22 19:08 elcasteel

Visit the preview URL for this PR (updated for commit 4bdad62):

https://gloo-edge--pr6897-istio-host-rewrite-fb5fpfwl.web.app

(expires Thu, 01 Sep 2022 19:09:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Aug 05 '22 19:08 github-actions[bot]

Issues linked to changelog: https://github.com/solo-io/gloo/issues/6538

solo-changelog-bot[bot] avatar Aug 05 '22 20:08 solo-changelog-bot[bot]

/kick build-bot didn't restart after changelog-bot's merge

elcasteel avatar Aug 25 '22 20:08 elcasteel

/kick consul tests

elcasteel avatar Aug 25 '22 20:08 elcasteel