CI test flake: Kube2e: gateway tests with virtual service with a mix of valid and invalid virtual services

[elcasteel]

Gloo Edge Version

1.12.x (beta)

Kubernetes Version

No response

Describe the bug

Error:

BeforeEach] propagates the valid virtual services to envoy 
/home/runner/work/gloo/gloo/test/kube2e/gateway/gateway_test.go:707

  Expected an error, got nil

  /home/runner/work/gloo/gloo/test/kube2e/gateway/gateway_test.go:668

These tests enable and disable strict validation and sometimes the updated setting is not propagated by the time we check to make sure it is enabled.

The test tries to write an invalid resource and expects it to fail so I think if we wanted to fix it with an Eventually we would need to do something like:

Eventually:
    try to write the invalid resource
    if rejected: success
    if accepted: delete the resource, retry

Steps to reproduce the bug

Run Ci

Expected Behavior

deterministic tests

Additional Context

No response

[jenshu]

https://github.com/solo-io/gloo/runs/7339699207?check_suite_focus=true

[elcasteel]

https://github.com/solo-io/gloo/runs/7399154173?check_suite_focus=true

[ashishb-90]

https://github.com/solo-io/gloo/runs/7452064700?check_suite_focus=true

2022-07-21T15:23:45.1269030Z [Fail] Kube2e: gateway tests with virtual service with a mix of valid and invalid virtual services [BeforeEach] propagates the valid virtual services to envoy 
2022-07-21T15:23:45.1273642Z /home/runner/work/gloo/gloo/test/kube2e/gateway/gateway_test.go:660