solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Expose ...OrderAdjustmentsRecalculator#calculate_eligibility bug

Open julienanne opened this issue 2 years ago • 1 comments
trafficstars

Summary

Spec to expose the inaccurate adjustment eligibility with shipping promotion action during Spree::Promotion::OrderAdjustmentsRecalculator call The issue #2387 expose many different way to have the trouble and to correct them temporary but not definitively ;) Sorry but can't, at the moment, propose a correction PR just a failing spec to expose the trouble for inspiration. I make it draft for the moment.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

julienanne avatar Mar 02 '23 15:03 julienanne

Thanks, @julienanne. Marking it as a draft for now.

waiting-for-dev avatar Mar 03 '23 05:03 waiting-for-dev