solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Published 20 hours ago • verified publisher icon solidusio

#4368 Admin panel - users - edit exist user - update address field always return 200

Open dborovsky opened this issue 3 years ago • 4 comments

Issue: https://github.com/solidusio/solidus/issues/4368

dborovsky avatar Jun 20 '22 05:06 dborovsky

Thanks for your collaboration, @dborovsky!

I think it'd be good to start with a failing test to ensure that the work done is fixing it. Have you been able to isolate what caused the response to be a success even when the attributes weren't saved?

Please, let me know if you need anything.

waiting-for-dev avatar Jun 21 '22 03:06 waiting-for-dev

@dborovsky Thanks for the contribution, but I think the issue is in how addresses work in Solidus (they are immutable). The solution is a bit more involved. Do you still want to try working on it? I left some comments about what I currently think could solve the issue.

tvdeyen avatar Jun 23 '22 07:06 tvdeyen

Hi @tvdeyen @jarednorman @waiting-for-dev. Review please my last changes.

dborovsky avatar Jul 06 '22 13:07 dborovsky