Improving stock items management

[softr8]

trafficstars

The following items were addressed

• Filtering was working by single stock location, made it multiple
• Available stock items by variant was being filtered as well when specified a stock location
• Improved available stock locations list in new stock item select box

Checklist:

• [ ] I have followed Pull Request guidelines
• [ ] I have added a detailed description into each commit message
• [ ] I have updated Guides and README accordingly to this change (if needed)
• [ ] I have added tests to cover this change (if needed)
• [ ] I have attached screenshots to this PR for visual changes (if needed)

[aldesantis]

@softr8 any chance you could split the improvements into multiple commits? It would make the Git history much more useful! 🙏

[softr8]

@kennyadsl what about now?

[kennyadsl]

Hey @softr8, do you have any update here? Does my comment make sense for you as well?

[softr8]

@kennyadsl done! let me know if this needs more work 👍

[softr8]

Done

[kennyadsl]

@softr8 Thanks for the update Edwin. There's a spec failing that seems related to the PR, can you please take a look?

[softr8]

done! @kennyadsl

[jarednorman]

There's some conflicts that need resolving here.

[waiting-for-dev]

Hey @softr8, I rebased from master, and it looks like some tests are failing. I know it's been a while, but do you have a clue which could be the problem?

[codecov[bot]]

Codecov Report

Merging #3626 (e76677e) into main (568f4ed) will decrease coverage by 0.01%. The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main    #3626      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         563      563              
  Lines       13890    13889       -1     
==========================================
- Hits        12322    12320       -2     
- Misses       1568     1569       +1     

Impacted Files	Coverage Δ
core/lib/spree/deprecation.rb	44.44% <16.66%> (-2.62%)	:arrow_down:
.../controllers/spree/admin/stock_items_controller.rb	97.05% <100.00%> (-0.31%)	:arrow_down:
core/app/models/spree/variant/scopes.rb	100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more