solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

Node version should be checked when starting the script

Open DieTapete opened this issue 3 years ago • 5 comments
trafficstars

I just had to deal with some issues like https://github.com/solidjs/solid-start/issues/104 until i figured that the node version I used (12.13.0) was apparently not high enough. There should be a check on startup if the user is running the script with a supported node version and bail if thats not the case.

DieTapete avatar May 31 '22 21:05 DieTapete

Thats a good point, we need to make the DX around this better

nksaraf avatar Jun 17 '22 21:06 nksaraf

Wouldn't setting the engine field in the package.json enough for this case?

cstrnt avatar Jun 18 '22 10:06 cstrnt

I thought we did do that , but I also think we set it incorrectly to >=14

nksaraf avatar Jun 18 '22 17:06 nksaraf

Yeah it's a fun one. I did 14 because we need to support the build chain for Netlify, Vercel, and other AWS Lambda based providers. We use their Edge functions which don't even require Node but it's why we are here.

ryansolid avatar Jun 18 '22 20:06 ryansolid

Well, updated all the engines to 16 now.

ryansolid avatar Sep 29 '22 04:09 ryansolid