solid-docs icon indicating copy to clipboard operation
solid-docs copied to clipboard

Solid-start: Docs for the plugin options should be more explicit about relative paths.

Open viridia opened this issue 2 years ago • 2 comments

The doc should mention that the paths for routesDir and other directory options are resolved relative to the appRoot directory; whereas appRoot is resolved relative to the current directory. I initially assumed that all paths would be treated the same, that is, resolved relative to currentDir.

Also, at the present time appRoot cannot be an absolute path. (This may be a bug - if not, it should be documented.)

viridia avatar Feb 10 '23 23:02 viridia

Are you reading docs from https://docs.solidjs.com/? If so, the issue should be on the solid-docs-next repo. I can move it for you, but I'd like to know whether to just move this issue (which seems very clearly about the new docs) or all four of your issues (some of which I'm not sure).

edemaine avatar Feb 12 '23 18:02 edemaine

The other three issues are about solid.js - only this one pertains to solid-start. I didn't realize that there were separate doc projects.

viridia avatar Feb 12 '23 18:02 viridia

Deploy Preview for solid-docs ready!

Name Link
Latest commit 2ededaf480d81ad9e5bfd7008e7e594881f8b9bd
Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6416f0d58d09f100080c42b0
Deploy Preview https://deploy-preview-232--solid-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Mar 14 '23 16:03 netlify[bot]