solid-docs icon indicating copy to clipboard operation
solid-docs copied to clipboard

Missing SVG breaks ref binding tutorial

Open mootari opened this issue 3 years ago • 2 comments

In https://www.solidjs.com/tutorial/bindings_refs the canvas has the default style

canvas {
background-color: #666;
-webkit-mask: url(https://dev.solidjs.com/img/logo/dark-without-wordmark/logo.svg) 50% 50% no-repeat;
mask: url(https://dev.solidjs.com/img/logo/dark-without-wordmark/logo.svg) 50% 50% no-repeat;
}

However, the referenced SVG file is missing, resulting in an invisible canvas.

If I had to make an (uninformed) guess, I'd suspect the problem was introduced by https://github.com/solidjs/solid-docs/pull/163

My recommendation would be to not reuse assets from other repos, but instead include every referenced asset in solid-docs.

mootari avatar Aug 14 '22 13:08 mootari

Logo source: https://github.com/solidjs/solid-site/blob/main/public/img/logo/dark-without-wordmark/logo.svg

According to archive.org the logo was still present on 2022-08-01: https://web.archive.org/web/20220801124138/https://www.solidjs.com/img/logo/dark-without-wordmark/logo.svg

mootari avatar Aug 14 '22 13:08 mootari

If I had to make an (uninformed) guess, I'd suspect the problem was introduced by https://github.com/solidjs/solid-docs/pull/163

Another candidate might be the migration to vite 3: https://github.com/solidjs/solid-site/pull/358

mootari avatar Aug 14 '22 14:08 mootari