solid-primitives icon indicating copy to clipboard operation
solid-primitives copied to clipboard

Add `createEvent` and `createSubject`

Open devagrawal09 opened this issue 1 year ago • 5 comments

Adds solid-events as a primitive.

devagrawal09 avatar Oct 14 '24 09:10 devagrawal09

⚠️ No Changeset found

Latest commit: 378567e9cb5dc2776337660ecfe8d75071d7dcc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 14 '24 09:10 changeset-bot[bot]

The name events easily lends itself to confusion with UI Events. What you implement here is a message bus, not an event system.

atk avatar Oct 14 '24 10:10 atk

This should be extending the event-bus package I don’t want to have two packages for the same problem.

thetarnav avatar Oct 14 '24 10:10 thetarnav

Why does this depend on rxjs? Shouldn’t it only implement the same interface to be usable with it? Or it should be made explicit that it’s a wrapper around rxjs

thetarnav avatar Oct 14 '24 10:10 thetarnav

Why does this depend on rxjs

The rxjs dependency is temporary, I'll work on getting rid of that soon

This should be extending the event-bus package I don’t want to have two packages for the same problem.

Fair, this is mostly a separate primitive because it's a solidhack submission, if this makes more sense as an extension to event-bus I'm happy to contribute. I'll spend some time next week rewriting the internals to use event bus instead of rxjs. Would love to hear your ideas around what the api should look like if this were to be an extension to event-bus.

devagrawal09 avatar Oct 15 '24 06:10 devagrawal09