solana-web3.js icon indicating copy to clipboard operation
solana-web3.js copied to clipboard

Eliminate deprecated RPC methods

Open steveluscher opened this issue 1 year ago • 1 comments

The following deprecated methods are being removed in Agave 2.0:

  • confirmTransaction
  • getSignatureStatus
  • getSignatureConfirmation
  • getTotalSupply
  • getConfirmedSignaturesForAddress
  • getConfirmedBlock
  • getConfirmedBlocks
  • getConfirmedBlocksWithLimit
  • getConfirmedTransaction
  • getConfirmedSignaturesForAddress2
  • getRecentBlockhash
  • getFees
  • getFeeCalculatorForBlockhash
  • getFeeRateGovernor
  • getSnapshotSlot

Clean all references and code for these from web3.js.

steveluscher avatar Jun 26 '24 18:06 steveluscher

I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

steveluscher avatar Jun 30 '24 18:06 steveluscher

I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

Hi Steve,

Is there an estimate on when the new library will be released? Or, if it is already released, can you help me with a link?

logandelafosse avatar Aug 30 '24 14:08 logandelafosse

Hey @sekaieth; you can follow along with the Release Candidates here. It's looking like the final will come shortly after Solana Breakpoint this year.

steveluscher avatar Aug 30 '24 17:08 steveluscher

Thanks!

I'm on a wallet team. Will the Agave 2.0 fork break my application if we don't upgrade this sdk immediately?

logandelafosse avatar Aug 30 '24 17:08 logandelafosse

The versions aren't related. @solana/web3.js 2.0 breaks all APIs from the application perspective, not the network perspective. There are no RPC API changes between the network at 1.18 or 2.0, except that some long-deprecated methods have been permanently removed.

steveluscher avatar Aug 30 '24 18:08 steveluscher

Thanks!

logandelafosse avatar Aug 30 '24 19:08 logandelafosse

This is done in 2.0. We're not going to remove them in the 1.x line.

steveluscher avatar Oct 22 '24 23:10 steveluscher

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

github-actions[bot] avatar Oct 30 '24 08:10 github-actions[bot]