solana-program-library icon indicating copy to clipboard operation
solana-program-library copied to clipboard

Suggestion: use default prettier settings

Open mikemaccana opened this issue 1 year ago • 1 comments

I noticed the Token Extension examples look odd and thought there wasn't any linter set up, and then I saw https://github.com/solana-labs/solana-program-library/pull/7115.

Suggestion: use two spaces per prettier defaults, StandardJS, node style guide, idiomatic JS, AirBnB style guide, MDN, Google Style guide, codepen, and jsfiddle.

Not my own personal preference, but if you want people to use your examples, it's better to fit in.

mikemaccana avatar Aug 14 '24 19:08 mikemaccana

PRs welcome! Can't say for sure we'll use all of them, so maybe best to do one at a time. Regardless happy to consider better formatting.

buffalojoec avatar Aug 15 '24 00:08 buffalojoec

This is our Solana-wide Prettier config. I hate it too, but I didn't get here early enough to have a say.

See also https://github.com/solana-labs/eslint-config-solana.

In any case, your suggestions belong on the https://github.com/solana-labs/prettier-config-solana repo.

steveluscher avatar Oct 17 '24 20:10 steveluscher