developer-content icon indicating copy to clipboard operation
developer-content copied to clipboard

fix and improve token-program-advance course

Open wuuer opened this issue 1 year ago • 1 comments

Problem

[creating NFTs with Metaplex] link is wrong. [previous chapter] link is wrong. [Transfering Tokens] link is wrong. The import @solana/web3.js statements in the section Brun Tokens are wrong. The return value type "web3.Transaction" is wrong in the section Brun Tokens. Missing delegate account for demonstration for the section Delegating tokens. A wrong argument passes to calling the revoke function in the typescript for Revoke Delegate. Missing some instructions for Delegating tokens, Revoke Delegate, and Burn Tokens.

Summary of Changes

Delete "web3." for "web3.Transaction" in the section Brun Tokens. Using the system program as the delegate in the typescript of Delegating tokens. Add some instructions for Delegating tokens, Revoke Delegate, and Burn Tokens. Fix [creating NFTs with Metaplex] link. Fix [previous chapter] link. Fix [Transferring Tokens] link. Fix the import @solana/web3.js statements in the section Brun Tokens. Fix a wrong argument passed to calling the revoke function in the typescript for Revoke Delegate.

wuuer avatar Sep 27 '24 02:09 wuuer

Hey @wuuer ! You already have a PR open that fixes https://token-program-advanced.md/ - https://github.com/solana-foundation/developer-content/pull/342 - please don't make multiple PRs for the same lesson, it splits the conversation into too many places.

mikemaccana avatar Oct 02 '24 08:10 mikemaccana

This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Nov 27 '24 00:11 github-actions[bot]