developer-content icon indicating copy to clipboard operation
developer-content copied to clipboard

fix and improve token-program.md,token-program-advance.md and close-mint.md

Open wuuer opened this issue 1 year ago • 6 comments

Problem

token-program.md

no try/catch for async/await calls, which is not following CONTRIBUTING.md. [Token Extensions Program] link is wrong. [add a second account on devnet] link is wrong. wrong ts command in the section [Create an Associated Token Account to store the tokens]. console.log displays a wrong explorer link due to "!".

token-program-advance.md

[creating NFTs with Metaplex] link is wrong. [previous chapter] link is wrong. [Transfering Tokens] link is wrong. The import @solana/web3.js statements in the section Brun Tokens are wrong. The return value type "web3.Transaction" is wrong in the section Brun Tokens. Missing delegate account for demonstration for the section Delegating tokens. A wrong argument passes to calling the revoke function in the typescript for Revoke Delegate. Missing some instructions for Delegating tokens, Revoke Delegate, and Burn Tokens.

close-mint.md

TERMINOLOGY "mint" is not proper in the context "In this lab, we'll create a mint with the close mint extension.". missing typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node] missing typescript code example for importing our new function in the section [3. Create a mint with close authority] "mintInfo" is redeclared in the typescript.

Summary of Changes

token-program.md

add try/catch for async/await calls following CONTRIBUTING.md. delete unnecessary "!" for generating a wrong explorer link. add some missing instructions. fix a wrong ts command for the section [Create an Associated Token Account to store the tokens].

token-program-advance.md

Delete "web3." for "web3.Transaction" in the section Brun Tokens. Using the system program as the delegate in the typescript of Delegating tokens. Add some instructions for Delegating tokens, Revoke Delegate, and Burn Tokens. Fix [creating NFTs with Metaplex] link. Fix [previous chapter] link. Fix [Transferring Tokens] link. Fix the import @solana/web3.js statements in the section Brun Tokens. Fix a wrong argument passed to calling the revoke function in the typescript for Revoke Delegate.

close-mint.md

change "mint" to "token mint account". add a typescript code example for using an account on devnet while calling "initializeKeypair" in the section [2. Run validator node] add a typescript code example for importing our new function in the section [3. Create a mint with close authority] change "const mintInfo" to "let mintInfo" because "mintInfo" is used again in the "CLOSE MINT" code part.

wuuer avatar Aug 24 '24 10:08 wuuer

Thanks @wuuer ! Just double checking - is this for the superteam lesson updates bounty?

mikemaccana avatar Aug 26 '24 13:08 mikemaccana

Thanks @wuuer ! Just double checking - is this for the superteam lesson updates bounty?

Yes.

wuuer avatar Aug 26 '24 13:08 wuuer

Hi @wuuer! Just a reminder to get the unboxed repos updated as discussed.

@mikemaccana Okay.

wuuer avatar Sep 27 '24 01:09 wuuer

@wuuer one more reminder! You have a good chance of winning this one if you get the other repos updated.

mikemaccana avatar Oct 02 '24 07:10 mikemaccana

@wuuer one more reminder! You have a good chance of winning this one if you get the other repos updated.

token and nfts

token-program

token extensions

close-mint

wuuer avatar Oct 03 '24 11:10 wuuer

@wuuer one more reminder! You have a good chance of winning this one if you get the other repos updated.

@mikemaccana

token and nfts

token-program

token extensions

close-mint

All of PRs are splited out:

https://github.com/solana-foundation/developer-content/pull/372#issuecomment-2378220855

wuuer avatar Oct 03 '24 11:10 wuuer

This pull request has been automatically marked as stale because it has not had recent activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Dec 03 '24 00:12 github-actions[bot]