react-native-modal-dropdown icon indicating copy to clipboard operation
react-native-modal-dropdown copied to clipboard

Update ListView to Flatlist

Open marshallshen opened this issue 6 years ago • 9 comments

Background

The original problem is caused by RN deprecating ListView in favor of FlatList, a solution is merged here.

However, a better solution IMO is to upgrade ListView entirely.

Testing

yarn test result with react-native-modal-dropdown 0.70: Screen Shot 2019-10-15 at 8 34 47 AM

yarn test result with the PR fork Screen Shot 2019-10-15 at 8 36 45 AM

marshallshen avatar Oct 15 '19 13:10 marshallshen

@sohobloo - any updates I should make for this?

marshallshen avatar Oct 27 '19 03:10 marshallshen

I had the same issue as well. Please merge this PR

nathan-pierotti avatar Oct 28 '19 22:10 nathan-pierotti

I am also getting same issue please merge this PR. @sohobloo

Rahulv2492 avatar Nov 21 '19 11:11 Rahulv2492

Any update on this @sohobloo .

Rahulv2492 avatar Nov 22 '19 05:11 Rahulv2492

@Rahulv2492 : also feel free to use the forked package as we keep it up to date: https://github.com/BuildU/react-native-modal-dropdown

In your package.json you need to import it as buildu/react-native-modal-dropdown

marshallshen avatar Nov 26 '19 15:11 marshallshen

Any update? We also see the same issue in our tests.

Gp2mv3 avatar Feb 27 '20 09:02 Gp2mv3

@Gp2mv3 I had a some problem and I added below line to my test. It works now.

jest.mock('deprecated-react-native-listview', () => {});

But still is a only workaround. @marshallshen's solution is better because replace depracated ListView

irekrog avatar Mar 08 '20 13:03 irekrog

++ issue, update please

ivankdev avatar Jun 05 '20 09:06 ivankdev

This should be merged to make the package usable.

gusrodriguez avatar Dec 18 '20 08:12 gusrodriguez