starknet-jvm icon indicating copy to clipboard operation
starknet-jvm copied to clipboard

ExecuteFromOutsideV2

Open MEJIOMAH17 opened this issue 7 months ago • 1 comments

Describe your changes

Added ability to execute transactions https://starknetjs.com/docs/next/guides/outsideExecution/

Breaking changes

  • [x] This issue contains breaking changes

open interface Account has new method. (Library user have to implement it)

MEJIOMAH17 avatar Apr 11 '25 16:04 MEJIOMAH17

I see CI failed - once you remove these unnecessary formatting changes it should pass 👌

franciszekjob avatar Apr 11 '25 21:04 franciszekjob

Overall looks good 👍

Key remarks:

  1. ATM there is support for v2, I think v1 should be included as well.
  2. We should allow the nonce to be automatically generated.
  3. We should mention outside execution in the docs (you can surely add it in separate PR)

Let me know if you need any clarification!

  1. I have raised the feature request for it and going to submit another PR.
  2. I have added random nonce generation/
  3. I have added method to the docs.

MEJIOMAH17 avatar Apr 14 '25 13:04 MEJIOMAH17

Codecov Report

Attention: Patch coverage is 84.66667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 66.24%. Comparing base (d5b8753) to head (4357e76). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
.../com/swmansion/starknet/account/StandardAccount.kt 68.75% 18 Missing and 2 partials :warning:
...nsion/starknet/account/NonceGenerationException.kt 0.00% 1 Missing :warning:
...n/com/swmansion/starknet/data/types/OutsideCall.kt 94.44% 1 Missing :warning:
.../swmansion/starknet/data/types/OutsideExecution.kt 97.43% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
- Coverage   67.66%   66.24%   -1.43%     
==========================================
  Files          91       98       +7     
  Lines        3260     3205      -55     
  Branches      373      378       +5     
==========================================
- Hits         2206     2123      -83     
- Misses        877      899      +22     
- Partials      177      183       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 15 '25 12:04 codecov-commenter