starknet-jvm
starknet-jvm copied to clipboard
ExecuteFromOutsideV2
Describe your changes
Added ability to execute transactions https://starknetjs.com/docs/next/guides/outsideExecution/
Breaking changes
- [x] This issue contains breaking changes
open interface Account has new method. (Library user have to implement it)
I see CI failed - once you remove these unnecessary formatting changes it should pass 👌
Overall looks good 👍
Key remarks:
- ATM there is support for v2, I think v1 should be included as well.
- We should allow the nonce to be automatically generated.
- We should mention outside execution in the docs (you can surely add it in separate PR)
Let me know if you need any clarification!
- I have raised the feature request for it and going to submit another PR.
- I have added random nonce generation/
- I have added method to the docs.
Codecov Report
Attention: Patch coverage is 84.66667% with 23 lines in your changes missing coverage. Please review.
Project coverage is 66.24%. Comparing base (
d5b8753) to head (4357e76). Report is 20 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 67.66% 66.24% -1.43%
==========================================
Files 91 98 +7
Lines 3260 3205 -55
Branches 373 378 +5
==========================================
- Hits 2206 2123 -83
- Misses 877 899 +22
- Partials 177 183 +6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.