react-native-gesture-handler icon indicating copy to clipboard operation
react-native-gesture-handler copied to clipboard

RNNativeViewHandler implementation on macOS

Open jfedak opened this issue 1 year ago • 2 comments

Description

Right now, we don't implement RNNativeViewHandler on macOS. This is quite important, because compotents like GH button require this handler to work. It is not as simple as it is on iOS, as there is no addTarget method in NSControl.

The second thing to consider here are methods pointInside and hitTest in RNGestureHandlerButton.m. It seems that the signature differs between iOS and macOS, so we need to override the correct methods.

Steps to reproduce

Snack or a link to a repository

Gesture Handler version

React Native version

Platforms

MacOS

JavaScript runtime

None

Workflow

None

Architecture

None

Build type

None

Device

None

Device model

No response

Acknowledgements

Yes

jfedak avatar Dec 15 '23 16:12 jfedak

Hey! 👋

It looks like you've omitted a few important sections from the issue template.

Please complete Steps to reproduce, Snack or a link to a repository, Gesture Handler version and React Native version sections.

github-actions[bot] avatar Dec 15 '23 16:12 github-actions[bot]

Hey! 👋

The issue doesn't seem to contain a minimal reproduction.

Could you provide a snack or a link to a GitHub repository under your username that reproduces the problem?

github-actions[bot] avatar Dec 15 '23 16:12 github-actions[bot]