react-native-gesture-handler icon indicating copy to clipboard operation
react-native-gesture-handler copied to clipboard

Published 20 hours ago • verified publisher icon software-mansion

Address compilation warnings

Open m-bert opened this issue 2 years ago • 1 comments

Description

It turns out that our code uses some deprecated functions. Also there were few more warnings, such as shadowed name or unused variables.

Some of included changes require digging into react-native source code to find alternative approach.

Fixes #2460

dispatch method

Based on @kkafar research in screens, I've replaced dispatch method with getEventData.

  • Here you can find how dispatch looks like in the source code.
  • Here you can see example change in react-native

Test plan

Tested that our example apps (paper and fabric) work as expected.

m-bert avatar Sep 20 '23 14:09 m-bert

Can someone merge this, for Christ?

jacksonlevine avatar Jan 24 '24 01:01 jacksonlevine