react-native-gesture-handler icon indicating copy to clipboard operation
react-native-gesture-handler copied to clipboard

Fix major issues with `LongPress` gesture on web

Open j-piasecki opened this issue 3 years ago • 0 comments

Description

This PR solves a few issues with LongPress gesture on web:

  • adds a duration property to events send by the gesture
  • fixes a bug where onBegin and onStart would not be called because of wrong oldState value in the events sent by the web implementation
  • fixes a bug where no events would be called if the gesture failed, now it correctly calls onBegin and onFinalize if the press time is too short

(Mostly) fixes https://github.com/software-mansion/react-native-gesture-handler/issues/2063

Test plan

Tested on the Example app.

j-piasecki avatar May 19 '22 09:05 j-piasecki