secure-ls icon indicating copy to clipboard operation
secure-ls copied to clipboard

Fixed #15 and #22

Open konsultaner opened this issue 6 years ago • 7 comments

@softvar I forgot to pull your changes before. You might need to update the builds again. I did not update the version, because you might want to fix things first before you release.

konsultaner avatar Jan 18 '19 14:01 konsultaner

Coverage Status

Coverage decreased (-4.9%) to 81.584% when pulling 8f48849cbe829cf1424d5084f7df73163e19452e on konsultaner:master into 679c12d34d8fe8c03b604550855b1f1acfb6ccb9 on softvar:master.

coveralls avatar Jan 18 '19 14:01 coveralls

@softvar since this is a breaking change you might want to update the version to 1.3.0

konsultaner avatar Jan 18 '19 14:01 konsultaner

It sure why the KDF was removed as it helps strengthen the provided key. The guts of the CryptoJSWordArray.random() should have been modified to use Crypto.getRandomValues(). The current random function isn’t generating a true random number.

@jas- I completely removed the default password

  • because a password should be provided by a trusted endpoint, not the browser
  • because the generated password was random an needed to be saved into the localstorage CryptoJSWordArray.random() was only used to generate an inital password if non was provided

konsultaner avatar Jan 20 '19 19:01 konsultaner

@konsultaner Could you please help in maintaining the coverage as well by adding test cases for the new code?

softvar avatar Jan 28 '19 19:01 softvar

@konsultaner Could you please help in maintaining the coverage as well by adding test cases for the new code?

@softvar I mostly removed code. I added tests for the code I added. This was mainly the console warnings for this.WarningEnum.ENCRYPTION_NAMESPACE_NOT_PROVIDED and this.WarningEnum.INSECURE_PASSWORD

If you find untested code I added let me know. I'll provide test for it then.

konsultaner avatar Jan 29 '19 12:01 konsultaner

@softvar I also changed some tests for the metaKey

konsultaner avatar Jan 29 '19 12:01 konsultaner

@softvar is there anything needed for you to accept the PR?

konsultaner avatar Feb 12 '19 08:02 konsultaner